From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH v3 4/6] mbuf: remove the rte_pktmbuf structure Date: Mon, 08 Sep 2014 10:29:49 +0200 Message-ID: <540D68FD.8040602@6wind.com> References: <1409240559-14447-5-git-send-email-bruce.richardson@intel.com> <1409837138-4401-1-git-send-email-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: Bruce Richardson , dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1409837138-4401-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 09/04/2014 03:25 PM, Bruce Richardson wrote: > From: Olivier Matz > > The rte_pktmbuf structure was initially included in the rte_mbuf > structure. This was needed when there was 2 types of mbuf (ctrl and > packet). As the control mbuf has been removed, we can merge the > rte_pktmbuf into the rte_mbuf structure. > > Advantages of doing this: > - the access to mbuf fields is easier (ex: m->data instead of m->pkt.data) > - make the structure more consistent: for instance, there was no reason > to have the ol_flags field in rte_mbuf > - it will allow a deeper reorganization of the rte_mbuf structure in the > next commits, allowing to gain several bytes in it > > Signed-off-by: Olivier Matz > > Updated to work with latest code, and to include new example apps. > > Changes in V2: > * Further updates to apply to latest HEAD on master > > Changes in V3: > * Updated to compile cleanly on 1.7.1 > > Signed-off-by: Bruce Richardson In app/test/packet_burst_generator.c, there is one remaining reference to "pkt." in a comment: #define RTE_MAX_SEGS_PER_PKT 255 /**< pkt.nb_segs is a 8-bit unsigned char. */ Acked-by: Olivier Matz