From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH 02/13] mbuf: reorder fields by time of use Date: Mon, 08 Sep 2014 12:17:06 +0200 Message-ID: <540D8222.3050800@6wind.com> References: <1409759378-10113-1-git-send-email-bruce.richardson@intel.com> <1409759378-10113-3-git-send-email-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: Bruce Richardson , dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1409759378-10113-3-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Bruce, On 09/03/2014 05:49 PM, Bruce Richardson wrote: > * Reorder the fields in the mbuf so that we have fields that are used$ > together side-by-side in the structure. This means that we have a$ > contiguous block of 8-bytes in the mbuf which are used to reset an mbuf$ > of descriptor rearm, and a block of 16-bytes of data (excluding flags) > which are set on RX from the received packet descriptor. Some unwanted $ characters here. > * Use dummy fields as appropraite to ensure alignment or to reserve gaps > for later field additions. s/appropraite/appropriate > * Place most items which are not used by fast-path RX separately at the end > of the structure so they can later be moved to a separate cache line. > [The l2/l3 length fields are not moved at this stage as doing so will > cause overflow to the next cache line]. > > Signed-off-by: Bruce Richardson Acked-by: Olivier Matz