From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH 03/13] mbuf: add packet_type field Date: Mon, 08 Sep 2014 12:17:12 +0200 Message-ID: <540D8228.809@6wind.com> References: <1409759378-10113-1-git-send-email-bruce.richardson@intel.com> <1409759378-10113-4-git-send-email-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: Bruce Richardson , dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1409759378-10113-4-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Bruce, On 09/03/2014 05:49 PM, Bruce Richardson wrote: > Replace a reserved slot with the new packet type field used to identify > the type of the packet, i.e. what protocols are used. > > Signed-off-by: Bruce Richardson > --- > lib/librte_mbuf/rte_mbuf.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index f136d37..8d0c6fb 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -146,7 +146,7 @@ struct rte_mbuf { > uint32_t reserved1; /**< Unused field. Required for padding */ > > /* remaining bytes are set on RX when pulling packet from descriptor */ > - uint16_t reserved2; /**< Unused field. Required for padding */ > + uint16_t packet_type; /**< Type of packet, e.g. protocols used */ > uint16_t data_len; /**< Amount of data in segment buffer. */ > uint32_t pkt_len; /**< Total pkt len: sum of all segments. */ > uint16_t l3_len:9; /**< L3 (IP) Header Length. */ > This patch adds a new fields that nobody uses. So why should we add it ?