From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH 0/6] Mbuf structure Rework, part 1 Date: Mon, 08 Sep 2014 14:32:44 +0200 Message-ID: <540DA1EC.10603@6wind.com> References: <1409154628-30825-1-git-send-email-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: Bruce Richardson , dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1409154628-30825-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Bruce, On 08/27/2014 05:50 PM, Bruce Richardson wrote: > This patch set does some initial pre-work to prepare the mbuf data structure > (and ixgbe vector driver to a lesser extent) for more major changes which > will follow on in a subsequent patch set. [See previous RFC patch set for > more indications of the future coming changes]. > > The main changes here are the flattening out of the mbuf data structure, with > much of it based off work by Olivier. The ctrlmbuf and pktmbuf structures are > now gone, as is the vlan_macip structure. However, in this set, the concept > of having a separate ctrl mbuf type is kept around. The plan is in a later set > when we expand the flags field to 64-bits, we can use a single bit in the flags > to indicate a control packet. For now, though, the ctrlmbuf functions and macros > just are aliases for the pktmbuf equivalents as much as possible. I'm wondering it "struct rte_kni_mbuf" should be updated accordingly each time "struct mbuf" is modified. Regards, Olivier