From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] build: remove duplicate checks for cflags
Date: Thu, 26 Jul 2018 10:10:42 +0200
Message-ID: <5416350.4EgPhb2RIe@xps>
References: <20180719142206.1478-1-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id DA2D01C01
 for <dev@dpdk.org>; Thu, 26 Jul 2018 10:10:48 +0200 (CEST)
In-Reply-To: <20180719142206.1478-1-bruce.richardson@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

19/07/2018 16:22, Bruce Richardson:
> There is no need to check for each library, driver and example whether
> certain cflags are supported. Instead of checking inside the loop, do
> so outside and reuse the value.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

The build log looks cleaner.

Applied, thanks