public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
* [PATCH] examples/ethtool: fix error message about ports limit
@ 2026-01-28 10:33 Thomas Monjalon
  2026-01-28 10:43 ` Bruce Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2026-01-28 10:33 UTC (permalink / raw)
  To: dev; +Cc: stable

The error message about the number of ports was swapping
the desired and maximum number of ports.

Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
Cc: stable@dpdk.org

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 examples/ethtool/ethtool-app/main.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/examples/ethtool/ethtool-app/main.c b/examples/ethtool/ethtool-app/main.c
index d380f69cea..b6bbae70d2 100644
--- a/examples/ethtool/ethtool-app/main.c
+++ b/examples/ethtool/ethtool-app/main.c
@@ -288,9 +288,7 @@ int main(int argc, char **argv)
 	if (cnt_ports == 0)
 		rte_exit(EXIT_FAILURE, "No available NIC ports!\n");
 	if (cnt_ports > MAX_PORTS) {
-		printf("Info: Using only %i of %i ports\n",
-			cnt_ports, MAX_PORTS
-			);
+		printf("Info: Using only %i of %i ports\n", MAX_PORTS, cnt_ports);
 		cnt_ports = MAX_PORTS;
 	}
 
-- 
2.52.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] examples/ethtool: fix error message about ports limit
  2026-01-28 10:33 [PATCH] examples/ethtool: fix error message about ports limit Thomas Monjalon
@ 2026-01-28 10:43 ` Bruce Richardson
  2026-02-16 22:08   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2026-01-28 10:43 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, stable

On Wed, Jan 28, 2026 at 11:33:50AM +0100, Thomas Monjalon wrote:
> The error message about the number of ports was swapping
> the desired and maximum number of ports.
> 
> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

>  examples/ethtool/ethtool-app/main.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/examples/ethtool/ethtool-app/main.c b/examples/ethtool/ethtool-app/main.c
> index d380f69cea..b6bbae70d2 100644
> --- a/examples/ethtool/ethtool-app/main.c
> +++ b/examples/ethtool/ethtool-app/main.c
> @@ -288,9 +288,7 @@ int main(int argc, char **argv)
>  	if (cnt_ports == 0)
>  		rte_exit(EXIT_FAILURE, "No available NIC ports!\n");
>  	if (cnt_ports > MAX_PORTS) {
> -		printf("Info: Using only %i of %i ports\n",
> -			cnt_ports, MAX_PORTS
> -			);
> +		printf("Info: Using only %i of %i ports\n", MAX_PORTS, cnt_ports);
>  		cnt_ports = MAX_PORTS;
>  	}
>  
> -- 
> 2.52.0
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] examples/ethtool: fix error message about ports limit
  2026-01-28 10:43 ` Bruce Richardson
@ 2026-02-16 22:08   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2026-02-16 22:08 UTC (permalink / raw)
  To: dev; +Cc: stable, Bruce Richardson

28/01/2026 11:43, Bruce Richardson:
> On Wed, Jan 28, 2026 at 11:33:50AM +0100, Thomas Monjalon wrote:
> > The error message about the number of ports was swapping
> > the desired and maximum number of ports.
> > 
> > Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-02-16 22:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-28 10:33 [PATCH] examples/ethtool: fix error message about ports limit Thomas Monjalon
2026-01-28 10:43 ` Bruce Richardson
2026-02-16 22:08   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox