From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH 7/7] eal/mem: use DMA mask check for legacy
 memory
Date: Thu, 1 Nov 2018 14:28:20 +0000
Message-ID: <543d1d8c-5dd5-e88f-3b9a-8aefe0add6d9@intel.com>
References: <20181031172931.11894-1-alejandro.lucero@netronome.com>
 <20181031172931.11894-8-alejandro.lucero@netronome.com>
 <545549d1-ba39-96e3-6bf9-219f9f5cba54@intel.com>
 <CAD+H993m3HstkbiGnDqL7NEzCCxvQD9g1hJ11KcmQRaRL659Kw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev <dev@dpdk.org>
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 01BA4683E
 for <dev@dpdk.org>; Thu,  1 Nov 2018 15:28:23 +0100 (CET)
In-Reply-To: <CAD+H993m3HstkbiGnDqL7NEzCCxvQD9g1hJ11KcmQRaRL659Kw@mail.gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 01-Nov-18 1:39 PM, Alejandro Lucero wrote:
> 
> 
> On Thu, Nov 1, 2018 at 10:40 AM Burakov, Anatoly 
> <anatoly.burakov@intel.com <mailto:anatoly.burakov@intel.com>> wrote:
> 
>     On 31-Oct-18 5:29 PM, Alejandro Lucero wrote:
>      > If a device reports addressing limitations through a dma mask,
>      > the IOVAs for mapped memory needs to be checked out for ensuring
>      > correct functionality.
>      >
>      > Previous patches introduced this DMA check for main memory code
>      > currently being used but other options like legacy memory and the
>      > no hugepages one need to be also considered.
>      >
>      > This patch adds the DMA check for those cases.
>      >
>      > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com
>     <mailto:alejandro.lucero@netronome.com>>
>      > ---
> 
>     IMO this needs to be integrated with patch 5.
> 
> 
> Not sure about this. patch 5 is a follow-up of patch 4, and this is to 
> add support for other EAL supported memory options.
> 

So it's a followup of patch 5, adding pretty much the same functionality 
(only in a different place). It's pretty safe to say these should be in 
the same patch, or at the very least one after the other.

-- 
Thanks,
Anatoly