From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] net/mlx5: remove not needed query if and rd
 from create qp
Date: Thu, 30 Mar 2017 18:08:28 +0100
Message-ID: <54445da3-1b84-e166-1e09-e78dd3decc6c@intel.com>
References: <20170330080645.30973-1-shahafs@mellanox.com>
 <69708566-2900-4781-B12A-AFFC7C7B2896@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
To: Yongseok Koh <yskoh@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 60361378E
 for <dev@dpdk.org>; Thu, 30 Mar 2017 19:08:32 +0200 (CEST)
In-Reply-To: <69708566-2900-4781-B12A-AFFC7C7B2896@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/30/2017 6:03 PM, Yongseok Koh wrote:
> 
> Hi,
> 
>> On Mar 30, 2017, at 1:06 AM, Shahaf Shuler <shahafs@mellanox.com> wrote:
>>
>> Since mlx5 PMD data path is on top of PRM, such verbs calls are
>> no longer needed.
>>
>> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
>> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> 
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
> 
> I ack the code change but one small suggestion regarding the commit header.
> It looks like 'if' means interface, 'rd' means the Resource Domain, and
> 'qp' means the Queue Pair. which are all mellanox specific terms and
> acronyms. My suggestion is:
> 
> net/mlx5: remove unnecessary Verbs library calls

Thanks for the suggestion, I was thinking about asking for clarification
on patch subject :)

> 
> And how about moving the details into the message body:
> 
> Remove unnecessary interface queries and the Resource Domain when creating
> the Queue Pair. Since mlx5 PMD data path is on top of native APIs, such
> Verbs library calls are no longer needed.
> 
> Thanks,
> Yongseok
>