From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Sune Subject: Re: [PATCH v4] KNI: use a memzone pool for KNI alloc/release Date: Tue, 21 Oct 2014 12:52:12 +0200 Message-ID: <54463ADC.8080901@bisdn.de> References: <1413586289-6694-1-git-send-email-marc.sune@bisdn.de> <11046523.OQamTbecJT@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Thomas Monjalon Return-path: In-Reply-To: <11046523.OQamTbecJT@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Thomas, v5: commit message arranged, all warnings from checkpatch.pl fixed except: WARNING: Macros with flow control statements should be avoided #104: FILE: lib/librte_kni/rte_kni.c:62: +#define KNI_MEM_CHECK(cond) do { if (cond) goto kni_fail; } while (0) a) This MACRO was there before, I just re-factored it to make it more readable. b) There are 4 lines exceeding 80cols due to long quoted strings. I followed kernel convention not to split them in multiple lines. Thanks and regards Marc On 21/10/14 10:29, Thomas Monjalon wrote: > Hi Marc, > > 2014-10-18 00:51, Marc Sune: >> This patch implements the KNI memzone pool in order to prevent >> memzone exhaustion when allocating/deallocating KNI interfaces. >> >> It adds a new API call, rte_kni_init(max_kni_ifaces) that shall >> be called before any call to rte_kni_alloc() if KNI is used. >> >> v2: Moved KNI fd opening to rte_kni_init(). Revised style. >> v3: Adapted kni examples/tests to rte_kni_init(). >> v4: Improved example integration. Fixed kni_memzone_pool_alloc/release() bug. >> >> Signed-off-by: Marc Sune > Thanks for the good work with Helin. > Before applying this patch, I'd like another version explaining in the > commit log why this change is needed. > And please use to checkpatch.pl to check and remove whitespace errors. > > Thanks