From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linhaifeng Subject: Re: [PATCH] add free hugepage function Date: Wed, 29 Oct 2014 14:49:05 +0800 Message-ID: <54508DE1.9090908@huawei.com> References: <1414551269-5820-1-git-send-email-haifeng.lin@huawei.com> <533710CFB86FA344BFBF2D6802E60286C7CAAB@SHSMSX101.ccr.corp.intel.com> <20141029034437.GA29486@mhcomputing.net> <533710CFB86FA344BFBF2D6802E60286C7CB42@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit Cc: "dev-VfR2kkLFssw@public.gmane.org" To: "Qiu, Michael" , Matthew Hall Return-path: In-Reply-To: <533710CFB86FA344BFBF2D6802E60286C7CB42-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 2014/10/29 13:26, Qiu, Michael wrote: > 在 10/29/2014 11:46 AM, Matthew Hall 写道: >> On Wed, Oct 29, 2014 at 03:27:58AM +0000, Qiu, Michael wrote: >>> I just saw one return path with value '0', and no any other place >>> return a negative value, so it is better to be designed as one >>> non-return function, >>> >>> +void >>> +rte_eal_hugepage_free(void) >>> +{ >>> + struct hugepage_file *hugepg_tbl = g_hugepage_table.hugepg_tbl; >>> + unsigned i; >>> + unsigned nr_hugefiles = g_hugepage_table.nr_hugefiles; >>> + >>> + RTE_LOG(INFO, EAL, "unlink %u hugepage files\n", nr_hugefiles); >>> + >>> + for (i = 0; i < nr_hugefiles; i++) { >>> + unlink(hugepg_tbl[i].filepath); >>> + hugepg_tbl[i].orig_va = NULL; >>> + } >>> +} >>> + >>> >>> Thanks, >>> Michael >> Actually, I don't think that's quite right. >> >> http://linux.die.net/man/2/unlink >> >> "On success, zero is returned. On error, -1 is returned, and errno is set >> appropriately." So it should be returning an error, and logging a message for >> a file it cannot unlink or people will be surprised with weird failures. > > Really need one message for unlink failed, but I'm afraid that if it > make sense for return an error code when application exit. > > Thanks > Michael >> It also had some minor typos / English in the comments but we can fix that too. >> >> Matthew. >> > > > Agree.May be it is not need to return error? -- Regards, Haifeng