From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jincheng Miao <jmiao-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] igb_uio: fix build for longterm kernel
	2.6.32.63
Date: Fri, 31 Oct 2014 09:54:34 +0800
Message-ID: <5452EBDA.2090706@redhat.com>
References: <1414657104-16141-1-git-send-email-jmiao@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
To: dev-VfR2kkLFssw@public.gmane.org
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1414657104-16141-1-git-send-email-jmiao-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

This patch will make RHEL6 build failed.

The root cause is that RHEL-based kernel is slightly different with=20
upstream kernel.
It has some functions (pci_num_vf, kstrtoul, etc) which don't exist in=20
upstream
longterm kernel.

For better compatibility, IMHO it is distinguishing RHEL-based kernel=20
and upstream one.
Using macro like:
```
#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 34) && \
     !(defined(RHEL_RELEASE_CODE) && RHEL_RELEASE_CODE >=3D=20
RHEL_RELEASE_VERSION(6, 3))

static int pci_num_vf(struct pci_dev *dev)
  {
```

But this is RHEL-specified fix. For other distros, if they have some=20
problem, we should
hack it in the same way.

Thanks and regards,
Jincheng Miao


On 10/30/2014 04:18 PM, Jincheng Miao wrote:
> There is a logical error in igb_uio/compat.h when define pci_num_vf().
> Only CONFIG_PCI_IOV enabled, this function could be defined.
>
> This patch fix the following error for linux-2.6.32.63:
> CC [M]  /root/dpdk-source/build/build/lib/librte_eal/linuxapp/igb_uio/i=
gb_uio.o
> /root/dpdk-source/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.c=
: In function =E2=80=98show_max_vfs=E2=80=99:
> /root/dpdk-source/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.c=
:75: error: implicit declaration of function =E2=80=98pci_num_vf=E2=80=99
>
> Signed-off-by: Jincheng Miao <jmiao-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>   lib/librte_eal/linuxapp/igb_uio/compat.h |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/librte_eal/linuxapp/igb_uio/compat.h b/lib/librte_eal/=
linuxapp/igb_uio/compat.h
> index 676fa1b..0af0cae 100644
> --- a/lib/librte_eal/linuxapp/igb_uio/compat.h
> +++ b/lib/librte_eal/linuxapp/igb_uio/compat.h
> @@ -21,7 +21,7 @@
>   #endif
>  =20
>   #if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 34) && \
> -	!defined(CONFIG_PCI_IOV)
> +	defined(CONFIG_PCI_IOV)
>  =20
>   static int pci_num_vf(struct pci_dev *dev)
>   {