From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 499ECC433ED for ; Tue, 13 Apr 2021 10:03:01 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id C093861370 for ; Tue, 13 Apr 2021 10:03:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C093861370 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F238C160DA5; Tue, 13 Apr 2021 12:02:59 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id A6583160D8E; Tue, 13 Apr 2021 12:02:58 +0200 (CEST) IronPort-SDR: kpd0QBrj3GEjVcwVKqXYRGZo9f0035KuccaTtVH7NU1Zp8731cUX5tWccK7YdGaGPWVMpDvDVx JG2iKiSliVqA== X-IronPort-AV: E=McAfee;i="6200,9189,9952"; a="214857274" X-IronPort-AV: E=Sophos;i="5.82,219,1613462400"; d="scan'208";a="214857274" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 03:02:53 -0700 IronPort-SDR: k537IKtDuICIPF3yp0w5TqhZY6A7F1JBFb5wqLa+NJOa9gtEhqzdX53mOE74fFEOV+SasVnVGw KPWboxSIempw== X-IronPort-AV: E=Sophos;i="5.82,219,1613462400"; d="scan'208";a="460526359" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.204.251]) ([10.213.204.251]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 03:02:52 -0700 To: Ivan Malov , dev@dpdk.org Cc: stable@dpdk.org, Andrew Rybchenko , Andy Moreton References: <20210410005143.28686-1-ivan.malov@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy Message-ID: <54610bd7-39b4-0b50-696e-5be022b07aa2@intel.com> Date: Tue, 13 Apr 2021 11:02:48 +0100 MIME-Version: 1.0 In-Reply-To: <20210410005143.28686-1-ivan.malov@oktetlabs.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] common/sfc_efx/base: fix indication of MAE encap. support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/10/2021 1:51 AM, Ivan Malov wrote: > The indication fields in the MCDI response are individual > bits, but the current code mistakenly compares the larger > dword with 1. This breaks encap. type discovery. Fix that. > > Fixes: 891408c45a63 ("common/sfc_efx/base: indicate MAE support for encapsulation") > Cc: stable@dpdk.org > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > Reviewed-by: Andy Moreton Applied to dpdk-next-net/main, thanks.