From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH 06/12] mbuf: add functions to get the name of an ol_flag Date: Mon, 10 Nov 2014 21:54:45 +0100 Message-ID: <54612615.1050405@6wind.com> References: <1415635166-1364-1-git-send-email-olivier.matz@6wind.com> <1415635166-1364-7-git-send-email-olivier.matz@6wind.com> <20141110171905.GF10776@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: jigsaw-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dev-VfR2kkLFssw@public.gmane.org To: Bruce Richardson Return-path: In-Reply-To: <20141110171905.GF10776@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Bruce, Thank you for the review. On 11/10/2014 06:29 PM, Bruce Richardson wrote: >> +/** >> + * Bit Mask to indicate what bits required for building TX context > > I don't understand this first line - is it accidentally included? Right, it's a mistake, I'll remove this line. >> + * Get the name of a RX offload flag >> + * >> + * @param mask >> + * The mask describing the flag. Usually only one bit must be set. >> + * Several bits can be given if they belong to the same mask. >> + * Ex: PKT_TX_L4_MASK. > TX mask given as an example for a function for RX flags is confusing. I'll remove the last two lines of the description as there is no example for RX flags. Regards, Olivier