dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Pernas Maradei <nicolas.pernas.maradei-M3NBUjLqch7QT0dZR+AlfA@public.gmane.org>
To: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
	Nicolas Pernas Maradei
	<nico-M3NBUjLqch7QT0dZR+AlfA@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] eal: allow virtual devices to be white/black listed
Date: Mon, 17 Nov 2014 16:40:19 +0000	[thread overview]
Message-ID: <546A24F3.4080107@emutex.com> (raw)
In-Reply-To: <20141117160041.GF17886-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>


On 17/11/14 16:00, Neil Horman wrote:
> I get that, I was more asking, why those values?  They seem a bit magic to me,
> and might benefit from some descriptive macros or comments so they make more
> sense
> Neil
OK, I get you now.

Maybe the diff is not very clear. I just left the original calls to 
rte_eal_devargs_add() with the original values which they looked clear 
to me but I don't mind improving the comments a bit and as you 
suggested, adding in some macros.

I'll wait for some more feedback before submitting a second version of 
the patch.

Thanks,
Nico.

  parent reply	other threads:[~2014-11-17 16:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-16 21:26 [PATCH] eal: allow virtual devices to be white/black listed Nicolás Pernas Maradei
     [not found] ` <1416173215-27533-1-git-send-email-nicolas.pernas.maradei-M3NBUjLqch7QT0dZR+AlfA@public.gmane.org>
2014-11-17 14:10   ` Neil Horman
     [not found]     ` <20141117141050.GD17886-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-11-17 14:58       ` Nicolas Pernas Maradei
     [not found]     ` <546A0BA2.3040306@emutex.com>
     [not found]       ` <546A0BA2.3040306-M3NBUjLqch7QT0dZR+AlfA@public.gmane.org>
2014-11-17 16:00         ` Neil Horman
     [not found]           ` <20141117160041.GF17886-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-11-17 16:40             ` Nicolas Pernas Maradei [this message]
     [not found]               ` <546A24F3.4080107-M3NBUjLqch7QT0dZR+AlfA@public.gmane.org>
2014-11-17 16:52                 ` Bruce Richardson
2014-11-17 21:17                   ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546A24F3.4080107@emutex.com \
    --to=nicolas.pernas.maradei-m3nbujlqch7qt0dzr+alfa@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
    --cc=nico-M3NBUjLqch7QT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).