From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Pernas Maradei Subject: Re: [PATCH] eal: allow virtual devices to be white/black listed Date: Mon, 17 Nov 2014 16:40:19 +0000 Message-ID: <546A24F3.4080107@emutex.com> References: <1416173215-27533-1-git-send-email-nicolas.pernas.maradei@emutex.com> <20141117141050.GD17886@hmsreliant.think-freely.org> <546A0BA2.3040306@emutex.com> <20141117160041.GF17886@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Neil Horman , Nicolas Pernas Maradei Return-path: In-Reply-To: <20141117160041.GF17886-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 17/11/14 16:00, Neil Horman wrote: > I get that, I was more asking, why those values? They seem a bit magic to me, > and might benefit from some descriptive macros or comments so they make more > sense > Neil OK, I get you now. Maybe the diff is not very clear. I just left the original calls to rte_eal_devargs_add() with the original values which they looked clear to me but I don't mind improving the comments a bit and as you suggested, adding in some macros. I'll wait for some more feedback before submitting a second version of the patch. Thanks, Nico.