From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 1/4] cryptodev: add rte_crypto_op_bulk_free
	function
Date: Mon, 20 Jun 2016 11:45:33 +0200
Message-ID: <5472998.Ej0WxNay6E@xps13>
References: <1466106543-209204-1-git-send-email-deepak.k.jain@intel.com>
 <1466106543-209204-2-git-send-email-deepak.k.jain@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, john.griffin@intel.com, fiona.trahe@intel.com,
 pablo.de.lara.guarch@intel.com
To: "Jain, Deepak K" <deepak.k.jain@intel.com>, declan.doherty@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 74E816CB1
 for <dev@dpdk.org>; Mon, 20 Jun 2016 11:45:36 +0200 (CEST)
Received: by mail-wm0-f46.google.com with SMTP id a66so70299220wme.0
 for <dev@dpdk.org>; Mon, 20 Jun 2016 02:45:36 -0700 (PDT)
In-Reply-To: <1466106543-209204-2-git-send-email-deepak.k.jain@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-06-16 20:49, Jain, Deepak K:
> From: Declan Doherty <declan.doherty@intel.com>
> 
> Adding rte_crypto_op_bulk_free to free up the ops in bulk
> so as to expect improvement in performance.
> 
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>

I wonder why these changes are dropped so late?

>  /**
> + * free crypto operation structure
> + * If operation has been allocate from a rte_mempool, then the operation will
> + * be returned to the mempool.
> + *
> + * @param	op	symmetric crypto operation
> + */

Please check punctuation, grammar and document every parameters.

> +static inline void
> +rte_crypto_op_bulk_free(struct rte_mempool *mpool, struct rte_crypto_op **ops,
> +		uint16_t nb_ops)