Re: [PATCH v3 01/14] Add compiling definations for IBM Power architecture

[Chao Zhu <chaozhu-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>]

Bruce,

Good point! I'll update the current patches.
Thanks for your suggestions!

On 2014/11/25 16:44, Bruce Richardson wrote:
> On Tue, Nov 25, 2014 at 11:51:13AM +0800, Chao Zhu wrote:
>> Neil,
>> Current Power related patches are not a full functional one. Some of the
>> libraries are not migrated. So
>> common_linuxapp_powerpc is used to turn off the uncompiled part.
> Hi Chao,
> just to re-echo what Neil says - this would be better as a
> defconfig_powerpc-native-linuxapp-gcc config file including common_linuxapp.
> Anything you need to turn off in the config can be turned off in the defconfig
> file after you include the common_linuxapp one - later definitions override
> earlier ones. It also makes things clearer to read as you end up with a
> powerpc config file that essentially reads as "use common linux settings except
> for this, and this, and this, etc...."
>
> 	Regards,
> 	/Bruce
>
>> This file
>> is a copy of the common_linuxapp. And this file is intended to be removed
>> when all of the libraries are migrated to Power. Actually, it's the current
>> common file for linux and other OS, such as BSD.  However, I didn't try the
>> compilation on BSD.  But this probably needs to be done.
>>
>> On 2014/11/24 6:02, Neil Horman wrote:
>>> On Sun, Nov 23, 2014 at 08:22:09PM -0500, Chao Zhu wrote:
>>>> To make DPDK run on IBM Power architecture, configuration files for
>>>> Power architecuture are added. Also, the compiling related .mk files are
>>>> added.
>>>>
>>>> Signed-off-by: Chao Zhu <chaozhu-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
>>>> ---
>>>>   config/common_linuxapp_powerpc              |  394 +++++++++++++++++++++++++++
>>>>   config/defconfig_ppc_64-power8-linuxapp-gcc |   40 +++
>>>>   mk/arch/ppc_64/rte.vars.mk                  |   39 +++
>>>>   mk/machine/power8/rte.vars.mk               |   57 ++++
>>>>   4 files changed, 530 insertions(+), 0 deletions(-)
>>>>   create mode 100644 config/common_linuxapp_powerpc
>>>>   create mode 100644 config/defconfig_ppc_64-power8-linuxapp-gcc
>>>>   create mode 100644 mk/arch/ppc_64/rte.vars.mk
>>>>   create mode 100644 mk/machine/power8/rte.vars.mk
>>>>
>>>> diff --git a/config/common_linuxapp_powerpc b/config/common_linuxapp_powerpc
>>>> new file mode 100644
>>>> index 0000000..d230a0b
>>>> --- /dev/null
>>>> +++ b/config/common_linuxapp_powerpc
>>> This filename is common_linuxapp_powerpc, but given that it explicitly specifies
>>> all the build options, there isn't really anything common about it.  I think
>>> what you want to do is rename this defconfig_powerpc-native-linuxapp-gcc, and
>>> have it include common_linuxapp, then change any power-specific option you see
>>> fit.
>>>
>>> Also, does BSD build on power?  I presume so. You likely want to create a
>>> corresponding bsd power config
>>>
>>