From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH v3 1/4] mbuf:add three TX offload flags and change three fields Date: Fri, 28 Nov 2014 12:18:45 +0100 Message-ID: <54785A15.1090301@6wind.com> References: <1417107801-9544-1-git-send-email-jijiang.liu@intel.com> <1417107801-9544-2-git-send-email-jijiang.liu@intel.com> <54784232.8030707@6wind.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01D9F2B9@SHSMSX101.ccr.corp.intel.com> <2601191342CEEE43887BDE71AB977258213BB218@IRSMSX105.ger.corp.intel.com> <547855C9.80507@6wind.com> <2601191342CEEE43887BDE71AB977258213BB258@IRSMSX105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: "Ananyev, Konstantin" , "Liu, Jijiang" , "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: <2601191342CEEE43887BDE71AB977258213BB258-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Konstantin, On 11/28/2014 12:13 PM, Ananyev, Konstantin wrote: >>> For the upper layer, I think there would be no big difference, what ways we will choose. >> >> I think the 2 informations are transversal, and that's why I would >> prefer 2 flags. Also, having 2 separate flags would also help to keep >> backward compatibility with previous versions. > > Hmm, not sure how we will break compatibility in that case? > If we'll make TX_IP_CKSUM to be 1 bit value (1 << X) then for current drivers nothing should change, no? Yes, you're right, sorry. Olivier