From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH] ixgbe: fix clang compile - remove truncation errors Date: Mon, 01 Dec 2014 10:59:48 +0100 Message-ID: <547C3C14.1040608@6wind.com> References: <1417188660-14587-1-git-send-email-bruce.richardson@intel.com> <20141130010514.GA19479@localhost.localdomain> <547C3052.4080106@6wind.com> <20141201094833.GA8760@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Bruce Richardson Return-path: In-Reply-To: <20141201094833.GA8760@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Bruce, On 12/01/2014 10:48 AM, Bruce Richardson wrote: >> I found that the following code works: >> >> tx_offload_mask.l2_len |= ~0; >> >> (note the '|=' instead of '=') >> >> I would avoid to create a macro. What do you think? >> >> Regards, >> Olivier > > Nice one - cleanest solution thus far, so I suggest we go with that option. Have > you got a patch for it ready? I'll submit the patch, after all it's my mistake! Regards, Olivier