From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH v5 3/3] mbuf:replace the inner_l2_len and the inner_l3_len fields Date: Fri, 05 Dec 2014 12:12:53 +0100 Message-ID: <54819335.20703@6wind.com> References: <1417532767-1309-1-git-send-email-jijiang.liu@intel.com> <1417532767-1309-4-git-send-email-jijiang.liu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: Jijiang Liu , dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1417532767-1309-4-git-send-email-jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi, On 12/02/2014 04:06 PM, Jijiang Liu wrote: > Replace the inner_l2_len and the inner_l3_len field with the outer_l2_len and outer_l3_len field, and rework csum forward engine and i40e PMD due to these changes. > > Signed-off-by: Jijiang Liu > --- > app/test-pmd/csumonly.c | 58 +++++++++++++++++++++------------------ > lib/librte_mbuf/rte_mbuf.h | 4 +- > lib/librte_pmd_i40e/i40e_rxtx.c | 38 +++++++++++++------------ > 3 files changed, 53 insertions(+), 47 deletions(-) > Acked-by: Olivier Matz One minor comment below: > @@ -303,8 +305,7 @@ process_outer_cksums(void *outer_l3_hdr, uint16_t outer_ethertype, > * TESTPMD_TX_OFFLOAD_* in ports[tx_port].tx_ol_flags. They control > * wether a checksum must be calculated in software or in hardware. The > * IP, UDP, TCP and SCTP flags always concern the inner layer. The > - * VxLAN flag concerns the outer IP and UDP layer (if packet is > - * recognized as a vxlan packet). > + * VxLAN flag concerns the outer IP(if packet is recognized as a vxlan packet). > */ > static void > pkt_burst_checksum_forward(struct fwd_stream *fs) Typo (no space before parenthesis) Regards, Olivier