From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Chemparathy Subject: Re: [PATCH 01/15] mk: introduce Tilera Tile architecture Date: Mon, 8 Dec 2014 13:34:02 -0800 Message-ID: <5486194A.8070106@ezchip.com> References: <1418029178-25162-1-git-send-email-zlu@ezchip.com> <1418029178-25162-2-git-send-email-zlu@ezchip.com> <20141208110912.GA10196@bricha3-MOBL3> <20141208142548.GB3237@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit To: Return-path: In-Reply-To: <20141208142548.GB3237-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 12/8/2014 6:25 AM, Neil Horman wrote: > On Mon, Dec 08, 2014 at 11:09:13AM +0000, Bruce Richardson wrote: >> On Mon, Dec 08, 2014 at 04:59:24PM +0800, Zhigang Lu wrote: >>> Add defconfig and rte.vars.mk files for Tile architecture. >>> >>> Signed-off-by: Zhigang Lu >>> Signed-off-by: Cyril Chemparathy >>> --- >>> config/defconfig_tile-tilegx-linuxapp-gcc | 78 +++++++++++++++++++++++++++++++ >>> mk/arch/tile/rte.vars.mk | 59 +++++++++++++++++++++++ >>> mk/machine/tilegx/rte.vars.mk | 58 +++++++++++++++++++++++ >>> 3 files changed, 195 insertions(+) >>> create mode 100644 config/defconfig_tile-tilegx-linuxapp-gcc >>> create mode 100644 mk/arch/tile/rte.vars.mk >>> create mode 100644 mk/machine/tilegx/rte.vars.mk >>> >> I think this should probably be the final patch in the series, rather than the >> first. It's generally best to set up all requirements first before enabling things >> in the compile time configuration. Once this patch is added, there is a non-functional >> target added for tile architecture. If it's added last, the moment the compile >> time config is added it works correctly. >> >> /Bruce >> >> > Agreed, this should be last. Also, just for clarity, you're posting this very > close to the 1.8 release. I presume your intent is to add this in for the 2.0 > release, correct? Fair point. Thanks. We'll reorder in the next version of this series. Thanks -- Cyril.