From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: Re: [PATCH v3 13/28] eal/pci: Prevent double registration for devargs_list Date: Thu, 11 Dec 2014 13:57:26 +0900 Message-ID: <54892436.2020107@igel.co.jp> References: <1416474399-16851-1-git-send-email-mukawa@igel.co.jp> <1418106629-22227-1-git-send-email-mukawa@igel.co.jp> <1418106629-22227-14-git-send-email-mukawa@igel.co.jp> <533710CFB86FA344BFBF2D6802E60286C9E203@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "nakajima.yoshihiro-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org" , "masutani.hitoshi-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org" , "menrigh-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org" To: "Qiu, Michael" , "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: <533710CFB86FA344BFBF2D6802E60286C9E203-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Michael, (2014/12/09 23:55), Qiu, Michael wrote: > On 2014/12/9 14:33, Tetsuya Mukawa wrote: >> The patch fixes rte_eal_devargs_add() not to register same device twic= e. >> >> Signed-off-by: Tetsuya Mukawa >> --- >> lib/librte_eal/common/eal_common_devargs.c | 35 +++++++++++++++++++++= +++++++++ >> 1 file changed, 35 insertions(+) >> >> diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_e= al/common/eal_common_devargs.c >> index 4c7d11a..f95a12d 100644 >> --- a/lib/librte_eal/common/eal_common_devargs.c >> +++ b/lib/librte_eal/common/eal_common_devargs.c >> @@ -44,6 +44,35 @@ >> struct rte_devargs_list devargs_list =3D >> TAILQ_HEAD_INITIALIZER(devargs_list); >> =20 >> + >> +/* find a entry specified by pci address or device name */ >> +static struct rte_devargs * >> +rte_eal_devargs_find(enum rte_devtype devtype, void *args) >> +{ >> + struct rte_devargs *devargs; >> + >> + if (args =3D=3D NULL) >> + return NULL; >> + >> + TAILQ_FOREACH(devargs, &devargs_list, next) { >> + switch (devtype) { >> + case RTE_DEVTYPE_WHITELISTED_PCI: >> + case RTE_DEVTYPE_BLACKLISTED_PCI: >> + if (eal_compare_pci_addr(&devargs->pci.addr, args) =3D=3D 0) >> + goto found; >> + break; >> + case RTE_DEVTYPE_VIRTUAL: >> + if (memcmp(&devargs->virtual.drv_name, args, >> + strlen((char *)args)) =3D=3D 0) >> + goto found; >> + break; >> + } >> + } >> + return NULL; >> +found: >> + return devargs; >> +} >> + >> /* store a whitelist parameter for later parsing */ >> int >> rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str= ) >> @@ -101,6 +130,12 @@ rte_eal_devargs_add(enum rte_devtype devtype, con= st char *devargs_str) >> break; >> } >> =20 >> + /* make sure there is no same entry */ >> + if (rte_eal_devargs_find(devtype, &devargs->pci.addr)) { > Am I miss something? If devtype =3D=3D RTE_DEVTYPE_VIRTUAL, what will h= appen? This will be issues. When I implement, I guess devargs->pci.addr and devargs->virtual.drv_name will have same address, because they are accessed as union. But it's rough coding and will have issue with some compilers. I will change it. Thanks, Tetsuya > Thanks, > Michael >> + RTE_LOG(ERR, EAL, "device already registered: <%s>\n", buf); >> + return -1; >> + } >> + >> TAILQ_INSERT_TAIL(&devargs_list, devargs, next); >> return 0; >> }