From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] examples/client_server_mp: add sigint
	handler to server
Date: Thu, 27 Sep 2018 14:48:38 +0200
Message-ID: <5489324.HoVYYzflKP@xps>
References: <1538047613-27309-1-git-send-email-rasland@mellanox.com>
 <9568922.17cOiG4SW6@xps>
 <20180927123053.GB776@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Raslan Darawsheh <rasland@mellanox.com>, dev@dpdk.org, shahafs@mellanox.com,
 orika@mellanox.com
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 425DA1B4AD
 for <dev@dpdk.org>; Thu, 27 Sep 2018 14:48:42 +0200 (CEST)
In-Reply-To: <20180927123053.GB776@bricha3-MOBL.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

27/09/2018 14:30, Bruce Richardson:
> On Thu, Sep 27, 2018 at 01:36:06PM +0200, Thomas Monjalon wrote:
> > 27/09/2018 13:26, Raslan Darawsheh:
> > > v2:
> > > 	- fix includes order
> > 
> > I'm afraid you will need a v3 to fix spacing :)
> > 
> > > --- a/examples/multi_process/client_server_mp/mp_server/main.c
> > > +++ b/examples/multi_process/client_server_mp/mp_server/main.c
> > > @@ -37,6 +37,7 @@
> > >  #include "common.h"
> > >  #include "args.h"
> > >  #include "init.h"
> > > +#include<signal.h>
> > 
> > A space is missing here.
> > 
> 
> Also, the norm in DPDK is to list all standard headers first, then the DPDK
> headers and finally the local headers. "signal.h" therefore should be
> further up in the file, with the first group.

I think he did that already in v3 :)