From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: Re: [PATCH v3 25/28] eal/pci: Remove pci_probe/close_all_drivers() Date: Thu, 11 Dec 2014 16:20:59 +0900 Message-ID: <548945DB.2070606@igel.co.jp> References: <1416474399-16851-1-git-send-email-mukawa@igel.co.jp> <1418106629-22227-1-git-send-email-mukawa@igel.co.jp> <1418106629-22227-26-git-send-email-mukawa@igel.co.jp> <533710CFB86FA344BFBF2D6802E60286C9ECF7@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "nakajima.yoshihiro-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org" , "masutani.hitoshi-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org" , "menrigh-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org" To: "Qiu, Michael" , "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: <533710CFB86FA344BFBF2D6802E60286C9ECF7-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" (2014/12/11 15:02), Qiu, Michael wrote: > Why you do not call pci_invoke_all_drivers() directly in former patches= ? > > What you do is first modify then remove.... I have received comments for former patches internally. And you know, this patch series are long. For those reviewers, I didn't want to change original patch separation radically. Anyway, I will merge a few patches. At the time I will merge these. Thanks, Tetsuya > Thanks, > Michael > > On 12/9/2014 2:34 PM, Tetsuya Mukawa wrote: >> These functions are actually wrappers of pci_invoke_all_drivers(). >> Just call it directly. >> >> Signed-off-by: Tetsuya Mukawa >> --- >> lib/librte_eal/common/eal_common_pci.c | 30 ++++---------------------= ----- >> 1 file changed, 4 insertions(+), 26 deletions(-) >> >> diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/c= ommon/eal_common_pci.c >> index 5ff7b49..5044d8e 100644 >> --- a/lib/librte_eal/common/eal_common_pci.c >> +++ b/lib/librte_eal/common/eal_common_pci.c >> @@ -130,29 +130,7 @@ pci_invoke_all_drivers(struct rte_pci_device *dev= , int type) >> return 1; >> } >> =20 >> -/* >> - * If vendor/device ID match, call the devinit() function of all >> - * registered driver for the given device. Return -1 if initializatio= n >> - * failed, return 1 if no driver is found for this device. >> - */ >> -static int >> -pci_probe_all_drivers(struct rte_pci_device *dev) >> -{ >> - return pci_invoke_all_drivers(dev, INVOKE_PROBE); >> -} >> - >> #if defined(RTE_LIBRTE_EAL_HOTPLUG) && defined(RTE_LIBRTE_EAL_LINUXAP= P) >> -/* >> - * If vendor/device ID match, call the devclose() function of all >> - * registered driver for the given device. Return -1 if initializatio= n >> - * failed, return 1 if no driver is found for this device. >> - */ >> -static int >> -pci_close_all_drivers(struct rte_pci_device *dev) >> -{ >> - return pci_invoke_all_drivers(dev, INVOKE_CLOSE); >> -} >> - >> static int >> rte_eal_pci_invoke_one(struct rte_pci_addr *addr, int type) >> { >> @@ -165,10 +143,10 @@ rte_eal_pci_invoke_one(struct rte_pci_addr *addr= , int type) >> =20 >> switch (type) { >> case INVOKE_PROBE: >> - ret =3D pci_probe_all_drivers(dev); >> + ret =3D pci_invoke_all_drivers(dev, INVOKE_PROBE); >> break; >> case INVOKE_CLOSE: >> - ret =3D pci_close_all_drivers(dev); >> + ret =3D pci_invoke_all_drivers(dev, INVOKE_CLOSE); >> break; >> } >> if (ret < 0) >> @@ -237,10 +215,10 @@ rte_eal_pci_probe(void) >> =20 >> /* probe all or only whitelisted devices */ >> if (probe_all) >> - ret =3D pci_probe_all_drivers(dev); >> + ret =3D pci_invoke_all_drivers(dev, INVOKE_PROBE); >> else if (devargs !=3D NULL && >> devargs->type =3D=3D RTE_DEVTYPE_WHITELISTED_PCI) >> - ret =3D pci_probe_all_drivers(dev); >> + ret =3D pci_invoke_all_drivers(dev, INVOKE_PROBE); >> if (ret < 0) >> rte_exit(EXIT_FAILURE, "Requested device " PCI_PRI_FMT >> " cannot be used\n", dev->addr.domain, dev->addr.bus,