From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jincheng Miao Subject: Re: [PATCH] kni: fix build on RHEL6.5 Date: Wed, 17 Dec 2014 11:26:57 +0800 Message-ID: <5490F801.3020807@redhat.com> References: <1418275627-17145-1-git-send-email-jmiao@redhat.com> <4943955.d3ixVqDNjM@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Thomas Monjalon Return-path: In-Reply-To: <4943955.d3ixVqDNjM@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 12/16/2014 11:21 PM, Thomas Monjalon wrote: > 2014-12-11 13:27, Jincheng Miao: >> RHEL6.5 kernel is based on 2.6.32. But there are two changing >> from 2.6.35: >> 1. socket struct is changed >> It wrappered previous wait_queue_head_t of socket to >> struct socket_wq. So for the kernel older than 2.6.35, we should >> directly use socket->wait instead. >> >> 2. new function sk_sleep() >> This function is implemented from 2.6.35 to obtain wait queue >> from struct sock. This patch adds a macro in kni/compat.h >> to be compatible with older kernels. > I don't understand the relation between RHEL-6.5 and the kernel 2.6.35. > The patch seems not related to RHEL at all. > Please start your explanations by describing what is the problem > you want to solve. Hi Thomas, This patch is working for resolving the problem I found on RHEL6.5: http://dpdk.org/ml/archives/dev/2014-December/009827.html Because the root cause is socket struct change from 2.6.35, so this patch also fits for all kernels older than 2.6.35. Sorry for the ambiguous description, I think the title should be: "kni: more compatibility for kernel older than 2.6.35" Regards, Jincheng Miao > > Thanks