From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: two tso related questions
Date: Wed, 17 Dec 2014 14:02:03 +0100
Message-ID: <54917ECB.3080404@6wind.com>
References: <CAF8yGaERQQ6DGPOotsJcXWuEzF=otRyA_ei7nffy8-bfZGWdNQ@mail.gmail.com>
 <CAKfHP0WY8n1tyxw7jbeBU2EgrAziyv+1h+xAuLyQ7Uu9AgiSzw@mail.gmail.com>
 <CAF8yGaFO+VXnvh1Er=oWUPrbGqc46fJdCp7Wez3gNgcjLCdqZw@mail.gmail.com>
 <CAKfHP0XNNqOSGsZ4zVn3va5f+fxRsZCP=YVdXpUx=eYTVO8xhw@mail.gmail.com>
 <CAF8yGaGSZgGrO19AKFxsP+Oq6rLmoYvmVBmsyes+QfXT2E6vJw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: Helmut Sim <simhelmut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Alex Markuze <alex-I7wstvAgZDk@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <CAF8yGaGSZgGrO19AKFxsP+Oq6rLmoYvmVBmsyes+QfXT2E6vJw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Helmut,

On 12/17/2014 08:17 AM, Helmut Sim wrote:
>>>>> While working on TSO based solution I faced the following two questions:
>>>>>
>>>>> 1.
>>>>> is there a maximum pkt_len to be used with TSO?, e.g. let's say if
>>>>> seg_sz
>>>>> is 1400 can the entire segmented pkt be 256K (higer than 64K) ?, then
>>>>> the
>>>>> driver gets a list of chanined mbufs while the first mbuf is set to TSO
>>>>> offload.

I think the limitations depend on:

- the window size advertised by the peer: your stack should handle this
   and not generate more packets that what the peer can receive

- the driver: on ixgbe, the maximum payload length is 2^18. I don't know
   if there is a limitation on number of chained descriptors.

I think we should define a way to know this limitation in the API. Maybe
a comment saying that the TSO length should not be higher than 256KB (or
fix it to 64KB in case future drivers do not support 256KB) is enough.

Regards,
Olivier