From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH] xenvirt: Fix build break on cmdline_parse_etheraddr call Date: Thu, 18 Dec 2014 10:26:46 +0100 Message-ID: <54929DD6.8080208@6wind.com> References: <1418835808-18803-1-git-send-email-nhorman@tuxdriver.com> <54929301.2010007@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: Neil Horman , dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <54929301.2010007-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi, On 12/18/2014 09:40 AM, Olivier MATZ wrote: > Hi Neil, > > On 12/17/2014 06:03 PM, Neil Horman wrote: >> Back in: >> >> commit aaa662e75c23c61a1d79bd4d1f9f35b4967c39db >> Author: Alan Carew >> Date: Fri Dec 5 15:19:07 2014 +0100 >> >> cmdline: fix overflow on bsd >> >> The author failed to fixup a call to cmdline_parse_etheraddr in xenvirt. This >> patch makes the needed correction to avoid a build break >> >> Signed-off-by: Neil Horman > > Sorry, I missed that one, thank you for fixing it. > > Acked-by: Olivier Matz Hmm, I agree with Thomas that sizeof(dict->addr) would be better as it explicitly uses the length of the field we write into. Regards, Olivier