From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v1 1/5] rawdev: introduce raw device library support Date: Sun, 14 Jan 2018 23:42:32 +0100 Message-ID: <5499617.M9cdW8ba0B@xps> References: <20180102125749.2379-1-shreyansh.jain@nxp.com> <20180102125749.2379-2-shreyansh.jain@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, hemant.agrawal@nxp.com, fiona.trahe@intel.com, rosen.xu@intel.com To: Shreyansh Jain Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5055C44C7 for ; Sun, 14 Jan 2018 23:43:05 +0100 (CET) In-Reply-To: <20180102125749.2379-2-shreyansh.jain@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, 02/01/2018 13:57, Shreyansh Jain: > A device is DPDK has a flavor to it - ethernet, crypto, event etc. I don't understand this sentence. I guess it can be completely removed. > A rawdevice represents a generic device map-able to a device flavour > not being currently handled out-of-the-box by DPDK framework. > A device which can be scanned on an installed bus (pci, fslmc, ...) > or instantiated through devargs, can be interfaced using > standardized APIs just like other standardized devices. > > This library introduces an API set which can be plugged on the > northbound side to the application layer, and on the southbound side > to the driver layer. > > The APIs of rawdev library exposes some generic operations which can > enable configuration and I/O with the raw devices. You should explain that it uses some opaque pointers. > Signed-off-by: Shreyansh Jain > --- > lib/librte_rawdev/Makefile | 27 ++ > lib/librte_rawdev/rte_rawdev.c | 540 ++++++++++++++++++++++++++++ > lib/librte_rawdev/rte_rawdev.h | 586 ++++++++++++++++++++++++++++++ > lib/librte_rawdev/rte_rawdev_pmd.h | 588 +++++++++++++++++++++++++++++++ > lib/librte_rawdev/rte_rawdev_version.map | 33 ++ Please add an entry in MAINTAINERS with EXPERIMENTAL tag. Sorry, no time to review the code myself. Thanks