From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Zolotarov Subject: Re: [PATCH 0/6] Enable VF RSS for Niantic Date: Wed, 24 Dec 2014 10:01:39 +0200 Message-ID: <549A72E3.9060606@cloudius-systems.com> References: <1418897516-25918-1-git-send-email-vladz@cloudius-systems.com> <5492D13C.4020006@cloudius-systems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" To: "Ouyang, Changchun" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 12/24/14 08:37, Ouyang, Changchun wrote: > > Hi, > > I have v3 patch for this to resolve your comments, > > We can discuss on v3 patch if there are further comments. > I'm looking at your v3 patchset right now... ;) > Thanks > > Changchun > > *From:*Vladislav Zolotarov [mailto:vladz-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org] > *Sent:* Sunday, December 21, 2014 4:02 PM > *To:* Ouyang, Changchun > *Cc:* dev-VfR2kkLFssw@public.gmane.org > *Subject:* RE: [PATCH 0/6] Enable VF RSS for Niantic > > > On Dec 19, 2014 3:35 AM, "Ouyang, Changchun"=20 > > wrote: > > > > My response as below. > > > > > > > > From: Vlad Zolotarov [mailto:vladz-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org=20 > ] > > Sent: Thursday, December 18, 2014 9:06 PM > > To: dev-VfR2kkLFssw@public.gmane.org ; Ouyang, Changchun > > Subject: Re: [PATCH 0/6] Enable VF RSS for Niantic > > > > > > > > > > > > On 12/18/14 12:11, Vlad Zolotarov wrote: > >> > >> From: Changchun Ouyang > > >> > >> > >> > >> This patch enables VF RSS for Niantic, which allow each VF having=20 > at most 4 queues. > >> > >> The actual queue number per VF depends on the number of VF: > >> > >> VF number from 1~32: 4 queues per VF; > >> > >> VF number from 33~max vf num: 2 queues per VF; > >> > >> > >> > >> On host, to enable VF RSS functionality, mq mode should be set as=20 > ETH_MQ_RX_VMDQ_RSS > >> > >> or ETH_MQ_RX_RSS mode, and SRIOV mode should be activated. > >> > >> It also needs config VF RSS information like hash function, RSS=20 > key, RSS key length. > > > > > > This patch series is missing a few things: > > > > Taking into the consideration the number of Rx queues requested by a=20 > user in the rte_eth_dev_configure(). > > > > Changchun: yes, will have a v2 to consider it, as I say in my=20 > previous response. > > I must have joined the mailing list after your v2 series. I'll take a=20 > look in the web for it. > > > > > dev->dev_ops->reta_query used by a rte_eth_dev_rss_reta_query() is=20 > still not initialized for a VF. Thus there is no way to query the RSS=20 > table > > > > Changchun: do you mean query rss table on guest? > > Of course. > > Niantic doesn=E2=80=99t have separate reta for a specific vf, the reta = is=20 > shared by pf and all vf. > > AFAIK the reta is statically divided between all available functions. > > So, first of all we need a way to know that is the size of a single VF=20 > partition in order to know how many RSS queues may be configured. > > Then we need an ability to query/set the contents of the corresponding=20 > reta partition like we can for PF. > > > > > Do you think of returning all reta contents for each vf make sense? =20 > Or any other insight here? > > > > rte_eth_dev_info_get() returns reta_size =3D=3D 0 when called for a V= F=20 > function. > > > > Changchun: same as above. > > > > Your insight here are welcome here. > > > > thanks > > > > Changchun > > > > >