From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Zolotarov Subject: Re: [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode Date: Sun, 04 Jan 2015 11:46:47 +0200 Message-ID: <54A90C07.5090507@cloudius-systems.com> References: <1419398584-19520-1-git-send-email-changchun.ouyang@intel.com> <1420355937-18484-1-git-send-email-changchun.ouyang@intel.com> <1420355937-18484-7-git-send-email-changchun.ouyang@intel.com> <54A8FE9A.60606@cloudius-systems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit To: "Ouyang, Changchun" , "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 01/04/15 11:01, Ouyang, Changchun wrote: >> -----Original Message----- >> From: Vlad Zolotarov [mailto:vladz-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org] >> Sent: Sunday, January 4, 2015 4:50 PM >> To: Ouyang, Changchun; dev-VfR2kkLFssw@public.gmane.org >> Subject: Re: [dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode >> >> >> On 01/04/15 09:18, Ouyang Changchun wrote: >>> Set VMDq RSS mode if it has VF(VF number is more than 1) and has RSS >> information. >>> Signed-off-by: Changchun Ouyang >>> --- >>> app/test-pmd/testpmd.c | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index >>> 8c69756..6230f8b 100644 >>> --- a/app/test-pmd/testpmd.c >>> +++ b/app/test-pmd/testpmd.c >>> @@ -1708,6 +1708,16 @@ init_port_config(void) >>> port->dev_conf.rxmode.mq_mode = >> ETH_MQ_RX_NONE; >>> } >>> >>> + if (port->dev_info.max_vfs != 0) { >>> + if (port->dev_conf.rx_adv_conf.rss_conf.rss_hf != 0) >>> + port->dev_conf.rxmode.mq_mode = >>> + ETH_MQ_RX_VMDQ_RSS; >>> + else { >>> + port->dev_conf.rxmode.mq_mode = >> ETH_MQ_RX_NONE; >>> + port->dev_conf.txmode.mq_mode = >> ETH_MQ_TX_NONE; >> >> And what about the txmode.mq_mode when RSS is available (the :if" clause)? > I think we can keep its original value for txmode.mq_mode, so don't change its value. How do you think of it? I agree that not changing a Tx mq_mode in both cases would be better. > Thanks > Changchun > >