From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Zolotarov Subject: Re: [PATCH v5 3/6] ixgbe: Get VF queue number Date: Thu, 08 Jan 2015 11:01:08 +0200 Message-ID: <54AE4754.1060000@cloudius-systems.com> References: <1420355937-18484-1-git-send-email-changchun.ouyang@intel.com> <1420612355-6666-1-git-send-email-changchun.ouyang@intel.com> <1420612355-6666-4-git-send-email-changchun.ouyang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit To: Ouyang Changchun , dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1420612355-6666-4-git-send-email-changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 01/07/15 08:32, Ouyang Changchun wrote: > Get the available Rx and Tx queue number when receiving IXGBE_VF_GET_QUEUES message from VF. > > Signed-off-by: Changchun Ouyang Reviewed-by: Vlad Zolotarov > > changes in v5 > - Add some 'FIX ME' comments for IXGBE_VF_TRANS_VLAN. > > --- > lib/librte_pmd_ixgbe/ixgbe_pf.c | 40 +++++++++++++++++++++++++++++++++++++++- > 1 file changed, 39 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c b/lib/librte_pmd_ixgbe/ixgbe_pf.c > index 495aff5..dbda9b5 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_pf.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c > @@ -53,6 +53,8 @@ > #include "ixgbe_ethdev.h" > > #define IXGBE_MAX_VFTA (128) > +#define IXGBE_VF_MSG_SIZE_DEFAULT 1 > +#define IXGBE_VF_GET_QUEUE_MSG_SIZE 5 > > static inline uint16_t > dev_num_vf(struct rte_eth_dev *eth_dev) > @@ -491,9 +493,41 @@ ixgbe_negotiate_vf_api(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf) > } > > static int > +ixgbe_get_vf_queues(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf) > +{ > + struct ixgbe_vf_info *vfinfo = > + *IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data->dev_private); > + uint32_t default_q = vf * RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool; > + > + /* Verify if the PF supports the mbox APIs version or not */ > + switch (vfinfo[vf].api_version) { > + case ixgbe_mbox_api_20: > + case ixgbe_mbox_api_11: > + break; > + default: > + return -1; > + } > + > + /* Notify VF of Rx and Tx queue number */ > + msgbuf[IXGBE_VF_RX_QUEUES] = RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool; > + msgbuf[IXGBE_VF_TX_QUEUES] = RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool; > + > + /* Notify VF of default queue */ > + msgbuf[IXGBE_VF_DEF_QUEUE] = default_q; > + > + /* > + * FIX ME if it needs fill msgbuf[IXGBE_VF_TRANS_VLAN] > + * for VLAN strip or VMDQ_DCB or VMDQ_DCB_RSS > + */ > + > + return 0; > +} > + > +static int > ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf) > { > uint16_t mbx_size = IXGBE_VFMAILBOX_SIZE; > + uint16_t msg_size = IXGBE_VF_MSG_SIZE_DEFAULT; > uint32_t msgbuf[IXGBE_VFMAILBOX_SIZE]; > int32_t retval; > struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > @@ -537,6 +571,10 @@ ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf) > case IXGBE_VF_API_NEGOTIATE: > retval = ixgbe_negotiate_vf_api(dev, vf, msgbuf); > break; > + case IXGBE_VF_GET_QUEUES: > + retval = ixgbe_get_vf_queues(dev, vf, msgbuf); > + msg_size = IXGBE_VF_GET_QUEUE_MSG_SIZE; > + break; > default: > PMD_DRV_LOG(DEBUG, "Unhandled Msg %8.8x", (unsigned)msgbuf[0]); > retval = IXGBE_ERR_MBX; > @@ -551,7 +589,7 @@ ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf) > > msgbuf[0] |= IXGBE_VT_MSGTYPE_CTS; > > - ixgbe_write_mbx(hw, msgbuf, 1, vf); > + ixgbe_write_mbx(hw, msgbuf, msg_size, vf); > > return retval; > }