From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH 0/7] Move EAL common functions Date: Fri, 09 Jan 2015 10:50:37 +0100 Message-ID: <54AFA46D.1080102@6wind.com> References: <1419521597-31978-1-git-send-email-rkerur@gmail.com> <54A11509.5050904@6wind.com> <20141229124723.GA27775@localhost.localdomain> <54A15420.2010401@6wind.com> <20150105122416.GG13152@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Bruce Richardson , Ravi Kerur Return-path: In-Reply-To: <20150105122416.GG13152@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi, Sorry for the late answer. On 01/05/2015 01:24 PM, Bruce Richardson wrote: > Hopefully that means two directories, not three. I think the existing common > folder should stay as it is, with the same name, and possibly add one new folder > for code that is common between BSD and Linux, but which would not be common > to other non-unix environments. I would be in favour of "common-posix" or > "common-unix" for such a folder name, if one is created. In the absense of > any other supported OS (or baremetal), I wonder as to the value of creating > such a separation at this point? The idea of common-posix (or common-unix) was a way to identify which code use the posix API, in the same logic than "common-x86". It would help when porting on other environment. But after thinking more about it, you are right, there is probably no real advantage yet and, as we only support unix environment, we cannot check that the separation would be correct. Regards, Olivier