From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Singh, Jasvinder" <jasvinder.singh@intel.com>
Subject: Re: [PATCH] mbuf: implement generic format for sched
	field
Date: Wed, 5 Dec 2018 12:22:30 +0000
Message-ID: <54CBAA185211B4429112C315DA58FF6D33668DFC@IRSMSX103.ger.corp.intel.com>
References: <20181123165423.134922-1-jasvinder.singh@intel.com>
 <3EB4FA525960D640B5BDFFD6A3D891268E800A9E@IRSMSX108.ger.corp.intel.com>
 <54CBAA185211B4429112C315DA58FF6D33666245@IRSMSX103.ger.corp.intel.com>
 <3EB4FA525960D640B5BDFFD6A3D891268E802F9A@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 5EB2E1B105
 for <dev@dpdk.org>; Wed,  5 Dec 2018 13:22:33 +0100 (CET)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E802F9A@IRSMSX108.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Dumitrescu, Cristian
> Sent: Tuesday, December 4, 2018 5:39 PM
> To: Singh, Jasvinder <jasvinder.singh@intel.com>; dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>
> Subject: RE: [PATCH] mbuf: implement generic format for sched field
>=20
> > >
> > > > +				uint8_t color;   /**< Color. */
> > >
> > > We should create a new file rte_color.h in a common place
> > > (librte_eal/common/include) to consolidate the color definition,
> > > which is currently replicated in too many places, such as:
> > > rte_meter.h, rte_mtr.h, rte_tm.h.
> > >
> > > We should include the rte_color.h file here (and in the above header
> > > files)
> > >
> > > We should also document the link between this field and the color
> > > enum
> > type
> > > (@see ...).
> >
> > Replacing the existing color definition with the above suggested one
> > in rte_meter.h (librte_meter) would be ABI break. We can do it
> > separately through different patch.
> >
> > >
>=20
> We can avoid any such issues in a two step process:
> 1. Create aliases to the new color in rte_meter.h, rte_mtr.h and rte_tm.h=
 at
> this point.
> 2. Announce deprecation of the existing color enums in favor of the new
> unified color enum at this point and remove during next release.
>=20
> Example:
> //file "rte_meter.h"
> #include <rte_color.h>
>=20
> #define rte_meter_color rte_color
> #define RTE_METER_GREEN RTE_COLOR_GREEN
> #define RTE_METER_YELLOW RTE_COLOR_YELLOW #define RTE_METER_RED
> RTE_COLOR_RED
>=20
> Makes sense?

Looks ok.  We will do this clean-up work in a separate patch instead of mix=
ing with mbuf patch. Thanks.

=20