From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: Re: [PATCH 05/12] lib/librte_vhost: copy host_memory_map from virtio-net.c to a new file virtio-net-cdev.c Date: Sun, 01 Feb 2015 13:04:02 +0900 Message-ID: <54CDA5B2.70001@igel.co.jp> References: <1422599787-12009-1-git-send-email-huawei.xie@intel.com> <1422599787-12009-6-git-send-email-huawei.xie@intel.com> <54CB572B.4040409@igel.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: "Xie, Huawei" , "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 2015/02/01 0:16, Xie, Huawei wrote: >>> + * map it to our address space. >>> + */ >>> +static int >>> +host_memory_map(struct virtio_net *dev, struct virtio_memory *mem, >>> + pid_t pid, uint64_t addr) >>> +{ >> Hi Xie, >> >> This patch only copy host_memory_map() to a new file. >> And actually the original function is removed at below patch. >> - "[PATCH 07/12] lib/librte_vhost: split set_memory_table into two parts" >> >> Is it difficult to remove and copy the function in this patch? > The purpose of splitting into several patches is to be reviewer friendly. > You could easily check the changes between each commit. OK, Thanks. Tetsuya >> Thanks, >> Tetsuya >>