From: Pawel Wodkowski <pawelx.wodkowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Declan Doherty
<declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"dev-VfR2kkLFssw@public.gmane.org"
<dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: [PATCH] bond: remove ol flags from transmit policy checks
Date: Mon, 02 Feb 2015 10:57:16 +0100 [thread overview]
Message-ID: <54CF49FC.4060906@intel.com> (raw)
In-Reply-To: <1422637337-6382-1-git-send-email-declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On 2015-01-30 18:02, Declan Doherty wrote:
> The Link bonding library is incorrectly using receive packet type flags
> in the transmit policy hashing functions, which would cause packets
> generated locally to be incorrectly distributed across the slave
> devices. This patch completely removes the dependency on the packet
> type flags and uses the ether_type from either the Ethernet header or
> the VLAN headers for branching.
>
> This patch also includes the associate changes in the test suite and in
> the packet_burst_generator code to remove the dependences on the packet
> type flags.
>
> Signed-off-by: Declan Doherty <declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
> app/test/packet_burst_generator.c | 24 +++++++++++-------------
> app/test/packet_burst_generator.h | 3 ++-
> app/test/test_link_bonding.c | 16 ++++++++--------
> app/test/test_pmd_perf.c | 2 +-
> lib/librte_pmd_bond/rte_eth_bond_pmd.c | 26 +++++++++++++++-----------
> 5 files changed, 37 insertions(+), 34 deletions(-)
>
Reviewed-by: Wodkowski Pawel <pawelx.wodkowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
next prev parent reply other threads:[~2015-02-02 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 17:02 [PATCH] bond: remove ol flags from transmit policy checks Declan Doherty
[not found] ` <1422637337-6382-1-git-send-email-declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-02-02 9:57 ` Pawel Wodkowski [this message]
[not found] ` <54CF49FC.4060906-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-02-02 11:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CF49FC.4060906@intel.com \
--to=pawelx.wodkowski-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).