From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pawel Wodkowski Subject: Re: [PATCH] bond: remove ol flags from transmit policy checks Date: Mon, 02 Feb 2015 10:57:16 +0100 Message-ID: <54CF49FC.4060906@intel.com> References: <1422637337-6382-1-git-send-email-declan.doherty@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit To: Declan Doherty , "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: <1422637337-6382-1-git-send-email-declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 2015-01-30 18:02, Declan Doherty wrote: > The Link bonding library is incorrectly using receive packet type flags > in the transmit policy hashing functions, which would cause packets > generated locally to be incorrectly distributed across the slave > devices. This patch completely removes the dependency on the packet > type flags and uses the ether_type from either the Ethernet header or > the VLAN headers for branching. > > This patch also includes the associate changes in the test suite and in > the packet_burst_generator code to remove the dependences on the packet > type flags. > > Signed-off-by: Declan Doherty > --- > app/test/packet_burst_generator.c | 24 +++++++++++------------- > app/test/packet_burst_generator.h | 3 ++- > app/test/test_link_bonding.c | 16 ++++++++-------- > app/test/test_pmd_perf.c | 2 +- > lib/librte_pmd_bond/rte_eth_bond_pmd.c | 26 +++++++++++++++----------- > 5 files changed, 37 insertions(+), 34 deletions(-) > Reviewed-by: Wodkowski Pawel