From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: Re: [PATCH v6] testpmd: Add port hotplug support Date: Tue, 03 Feb 2015 10:32:12 +0900 Message-ID: <54D0251C.2050407@igel.co.jp> References: <1421664027-17971-9-git-send-email-mukawa@igel.co.jp> <1422763322-13742-1-git-send-email-mukawa@igel.co.jp> <1422763322-13742-16-git-send-email-mukawa@igel.co.jp> <8CEF83825BEC744B83065625E567D7C2049DCAD2@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: "Iremonger, Bernard" , "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: <8CEF83825BEC744B83065625E567D7C2049DCAD2-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 2015/02/02 20:33, Iremonger, Bernard wrote >> /* >> * Work-around of a compilation error with ICC on invocations of the >> * rte_be_to_cpu_16() function. >> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst >> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst >> index 218835a..1cacbcf 100644 >> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst >> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > Hi Tetsuya, > > The doc changes should be in separate commit using the "doc: explaination" commit line. > >> @@ -808,6 +808,63 @@ The following sections show functions for configuring ports. >> >> Port configuration changes only become active when forwarding is started/restarted. >> >> +port attach >> +~~~~~~~~~~~ >> + >> +Attach a port specified by pci address or virtual device args. >> + >> +To attach a new pci device, the device should be recognized by kernel first. >> +Then it should be moved under DPDK management. >> +Finally the port can be attached to testpmd. >> +On the other hand, to attach a port created by virtual device, above steps are not needed. >> + >> +port attach (identifier) >> + >> +For example, to attach a port that pci address is 0000:02:00.0. > Reword " port that pci address is " to "port whose pci address is" Hi Bernard, Thanks, I will fix below comments like your suggestion. Tetsuya >> + >> +.. code-block:: console >> + >> + testpmd> port attach 0000:02:00.0 >> + Attaching a new port... >> + ... snip ... >> + Port 0 is attached. Now total ports is 1 >> + Done >> + >> +For example, to attach a port created by pcap PMD. >> + >> +.. code-block:: console >> + >> + testpmd> port attach eth_pcap0,iface=eth0 >> + Attaching a new port... >> + ... snip ... >> + Port 0 is attached. Now total ports is 1 >> + Done >> + >> +In this case, identifier is "eth_pcap0,iface=eth0". >> +This identifier format is the same as "--vdev" format of DPDK applications. >> + >> +port detach >> +~~~~~~~~~~~ >> + >> +Detach a specific port. >> + >> +Before detaching a port, the port should be closed. >> +Also to remove a pci device completely from the system, first detach the port from testpmd. >> +Then the device should be moved under kernel management. >> +Finally the device can be remove using kernel pci hotplug functionality. > Reword "remove" to "removed" > >> +On the other hand, to remove a port created by virtual device, above steps are not needed. > Reword " created by virtual device" to "created by a virtual device" > >> + >> +port detach (port_id) >> + >> +For example, to detach a port 0. >> + >> +.. code-block:: console >> + >> + testpmd> port detach 0 >> + Detaching a port... >> + ... snip ... >> + Done >> + >> port start >> ~~~~~~~~~~ >> >> -- >> 1.9.1 > Regards, > > Bernard. >