From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: Re: [PATCH v6] testpmd: Add port hotplug support Date: Tue, 03 Feb 2015 10:34:21 +0900 Message-ID: <54D0259D.6020205@igel.co.jp> References: <1421664027-17971-9-git-send-email-mukawa@igel.co.jp> <1422763322-13742-16-git-send-email-mukawa@igel.co.jp> <8CEF83825BEC744B83065625E567D7C2049DCAD2@IRSMSX108.ger.corp.intel.com> <1688512.MY7Nexz1BF@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Thomas Monjalon , "Iremonger, Bernard" Return-path: In-Reply-To: <1688512.MY7Nexz1BF@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 2015/02/02 20:57, Thomas Monjalon wrote: > 2015-02-02 11:33, Iremonger, Bernard: >> From: Tetsuya Mukawa [mailto:mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org] >>> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst >>> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst >> Hi Tetsuya, >> >> The doc changes should be in separate commit using the "doc: explaination" commit line. > I agree that new docs should be in a separate commit. > Though when updating some code (like here), it's a good idea to update the doc > in the same commit. Then the change is atomic. > > If you want to figure which patches are updating the doc, it should be possible > to have a filter on "+++ b/doc/". > Hi Thomas, I appreciate your comment. I will follow this guideline. Thanks, Tetsuya