* [PATCH v2] testpmd: fix port parsing in show port info command
@ 2015-02-06 1:29 xuelin.shi-KZfg59tc24xl57MIdRCFDg
[not found] ` <1423186160-26035-1-git-send-email-xuelin.shi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: xuelin.shi-KZfg59tc24xl57MIdRCFDg @ 2015-02-06 1:29 UTC (permalink / raw)
To: olivier.matz-pdR9zngts4EAvxtiuMwx3w; +Cc: dev-VfR2kkLFssw
From: Xuelin Shi <xuelin.shi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
the port number type should be consistent with librte_cmdline,
else there is potential endian issue.
Signed-off-by: Xuelin Shi <xuelin.shi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
v2 change:
change port type to uint8
rephrase patch title
app/test-pmd/cmdline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 590e427..d5f31f2 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -5584,7 +5584,7 @@ cmdline_parse_token_string_t cmd_showport_what =
TOKEN_STRING_INITIALIZER(struct cmd_showport_result, what,
"info#stats#xstats#fdir#stat_qmap");
cmdline_parse_token_num_t cmd_showport_portnum =
- TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, INT32);
+ TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, UINT8);
cmdline_parse_inst_t cmd_showport = {
.f = cmd_showport_parsed,
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1423186160-26035-1-git-send-email-xuelin.shi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>]
* Re: [PATCH v2] testpmd: fix port parsing in show port info command [not found] ` <1423186160-26035-1-git-send-email-xuelin.shi-KZfg59tc24xl57MIdRCFDg@public.gmane.org> @ 2015-02-06 8:30 ` Olivier MATZ [not found] ` <54D47BB4.9020005-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Olivier MATZ @ 2015-02-06 8:30 UTC (permalink / raw) To: xuelin.shi-KZfg59tc24xl57MIdRCFDg; +Cc: dev-VfR2kkLFssw Hi, On 02/06/2015 02:29 AM, xuelin.shi-KZfg59tc24xl57MIdRCFDg@public.gmane.org wrote: > From: Xuelin Shi <xuelin.shi-KZfg59tc24xl57MIdRCFDg@public.gmane.org> > > the port number type should be consistent with librte_cmdline, > else there is potential endian issue. > > Signed-off-by: Xuelin Shi <xuelin.shi-KZfg59tc24xl57MIdRCFDg@public.gmane.org> > --- > v2 change: > change port type to uint8 > rephrase patch title > > app/test-pmd/cmdline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 590e427..d5f31f2 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -5584,7 +5584,7 @@ cmdline_parse_token_string_t cmd_showport_what = > TOKEN_STRING_INITIALIZER(struct cmd_showport_result, what, > "info#stats#xstats#fdir#stat_qmap"); > cmdline_parse_token_num_t cmd_showport_portnum = > - TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, INT32); > + TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, UINT8); > > cmdline_parse_inst_t cmd_showport = { > .f = cmd_showport_parsed, > Acked-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <54D47BB4.9020005-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH v2] testpmd: fix port parsing in show port info command [not found] ` <54D47BB4.9020005-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> @ 2015-02-15 15:46 ` Thomas Monjalon 0 siblings, 0 replies; 3+ messages in thread From: Thomas Monjalon @ 2015-02-15 15:46 UTC (permalink / raw) To: xuelin.shi-KZfg59tc24xl57MIdRCFDg; +Cc: dev-VfR2kkLFssw > > the port number type should be consistent with librte_cmdline, > > else there is potential endian issue. > > > > Signed-off-by: Xuelin Shi <xuelin.shi-KZfg59tc24xl57MIdRCFDg@public.gmane.org> > > Acked-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> Applied, thanks ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-15 15:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-06 1:29 [PATCH v2] testpmd: fix port parsing in show port info command xuelin.shi-KZfg59tc24xl57MIdRCFDg
[not found] ` <1423186160-26035-1-git-send-email-xuelin.shi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-02-06 8:30 ` Olivier MATZ
[not found] ` <54D47BB4.9020005-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-02-15 15:46 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).