From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ming Zhao <mzhao-82A4bShDkBpJQxFrfMEhiVaTQe2KTcn/@public.gmane.org>
Subject: "virtual" C++ keyword used in rte_devargs.h and causes
 compilation error in C++
Date: Fri, 06 Feb 2015 23:24:15 -0800
Message-ID: <54D5BD9F.7000902@luminatewireless.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: dev-VfR2kkLFssw@public.gmane.org
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

The code is in rte_devargs.h:

rte_devargs.h:

                /** Used if type is RTE_DEVTYPE_VIRTUAL. */
                struct {
                        /** Driver name. */
                        char drv_name[32];
                } virtual;
        };

Which caused clang compiler to report error when this file is included
by a cpp file, the error message is:

In file included from net/dpdk/testing/base-test.cc:3:
In file included from net/dpdk/testing/base-test.h:8:
third-party/dpdk/lib/librte_eal/common/include/rte_devargs.h:89:5:
error: 'virtual' can only appear on non-static
      member functions
                } virtual;
                  ^

I think we should try to pick another name for this field. I would
suggest calling it "vdev" instead, or I'll be happy to take another name
if someone comes with a different idea.

Thanks!
Ming