From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linhaifeng Subject: Re: [PATCH v2 09/11] lib/librte_vhost: vhost user support Date: Thu, 12 Feb 2015 18:19:27 +0800 Message-ID: <54DC7E2F.9030600@huawei.com> References: <1423717649-11818-1-git-send-email-huawei.xie@intel.com> <1423717649-11818-10-git-send-email-huawei.xie@intel.com> <54DC63AD.7020007@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit To: "Xie, Huawei" , "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 2015/2/12 17:28, Xie, Huawei wrote: > On 2/12/2015 4:28 PM, Linhaifeng wrote: >> >> On 2015/2/12 13:07, Huawei Xie wrote: >>> + >>> + /* This is ugly */ >>> + mapped_size = memory.regions[idx].memory_size + >>> + memory.regions[idx].mmap_offset; >>> + mapped_address = (uint64_t)(uintptr_t)mmap(NULL, >>> + mapped_size, >>> + PROT_READ | PROT_WRITE, MAP_SHARED, >>> + pmsg->fds[idx], >>> + 0); >> Just another ugly way: >> We can use the size of file to mmap then unmmap is not need align to the size of page. >> > Yes, this is like how cuses handle mmap. > We will add this into the to-do list, combine all the regions the first, > check if they belong to the same file, and then map each file once. > Seems there is no elegant way. > > There is another to do for mmap. If there are multiple virtio devices, > the memory are mapped for each virtio device. Actually we only need once. > Great minds think alike. The graceful way is qemu send a message to us to mmap whit which file and size then we not need to mmap for each virtio device. > > > -- Regards, Haifeng