Re: [PATCH v5 1/6] reorder: new reorder library

[Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>]

Hi Sergio,

On 02/18/2015 03:58 PM, Sergio Gonzalez Monroy wrote:
> This library provides reordering capability for out of order mbufs based
> on a sequence number in the mbuf structure.
>
> Signed-off-by: Reshma Pattan <reshma.pattan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Richardson Bruce <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> [...]
>
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -289,6 +289,9 @@ struct rte_mbuf {
>   		uint32_t usr;	  /**< User defined tags. See @rte_distributor_process */
>   	} hash;                   /**< hash information */
>
> +	/* sequence number - field used in distributor and reorder library */
> +	uint32_t seqn;
> +
>   	/* second cache line - fields only used in slow path or on TX */
>   	MARKER cacheline1 __rte_cache_aligned;
>

Just one small comment about rte_mbuf: the comment should be in doxygen
style.


Regards,
Olivier