From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: Re: [PATCH] i40e: fix build with gcc 5 Date: Thu, 19 Feb 2015 13:09:53 +0200 Message-ID: <54E5C481.6020701@redhat.com> References: <442c1d71592455d2f3c8df4cc944cc48c1092fc6.1424341431.git.pmatilai@redhat.com> <2601191342CEEE43887BDE71AB977258213F0C28@irsmsx105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: "Ananyev, Konstantin" , "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: <2601191342CEEE43887BDE71AB977258213F0C28-pww93C2UFcwu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 02/19/2015 01:05 PM, Ananyev, Konstantin wrote: > > >> -----Original Message----- >> From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Panu Matilainen >> Sent: Thursday, February 19, 2015 10:25 AM >> To: dev-VfR2kkLFssw@public.gmane.org >> Subject: [dpdk-dev] [PATCH] i40e: fix build with gcc 5 >> >> Eliminate embiguity in the condition which trips up a "logical not >> is only applied to the left..." warning from gcc 5, causing build >> failure with -Werror. >> >> Signed-off-by: Panu Matilainen >> --- >> lib/librte_pmd_i40e/i40e_rxtx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_rxtx.c >> index c9f1026..ede5405 100644 >> --- a/lib/librte_pmd_i40e/i40e_rxtx.c >> +++ b/lib/librte_pmd_i40e/i40e_rxtx.c >> @@ -613,7 +613,7 @@ check_rx_burst_bulk_alloc_preconditions(__rte_unused struct i40e_rx_queue *rxq) >> "rxq->nb_rx_desc=%d", >> rxq->rx_free_thresh, rxq->nb_rx_desc); >> ret = -EINVAL; >> - } else if (!(rxq->nb_rx_desc % rxq->rx_free_thresh) == 0) { >> + } else if (!(rxq->nb_rx_desc % rxq->rx_free_thresh == 0)) { > > Why just not: > else if (rxq->nb_rx_desc % rxq->rx_free_thresh != 0) > ? The same occurred to me right after hitting send, it'll make it a whole lot more obvious. I'll send another version. - Panu -