From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: Re: [PATCH v9 02/14] eal_pci: Add flag to hold kernel driver type Date: Thu, 19 Feb 2015 22:29:43 +0900 Message-ID: <54E5E547.2020806@igel.co.jp> References: <1424060073-23484-12-git-send-email-mukawa@igel.co.jp> <1424314187-25177-1-git-send-email-mukawa@igel.co.jp> <1424314187-25177-3-git-send-email-mukawa@igel.co.jp> <5677937.pUHUTuZF0f@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Return-path: In-Reply-To: <5677937.pUHUTuZF0f@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 2015/02/19 20:17, Thomas Monjalon wrote: >> @@ -152,6 +159,7 @@ struct rte_pci_device { >> uint16_t max_vfs; /**< sriov enable if not zero */ >> int numa_node; /**< NUMA node connection */ >> struct rte_devargs *devargs; /**< Device user arguments */ >> + enum rte_pt_driver pt_driver; /**< Driver of passthrough */ > [...] >> +static int >> +pci_get_kernel_driver_by_path(const char *filename, char *dri_name) > I think "kernel driver" is a good name. Why not using this name in the > pci_device struct to be more consistent? Hi Michael, Could you please let me know what do you think about it? Thanks Tetsuya > Thanks