From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: Re: [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc -dumpversion' output Date: Tue, 24 Feb 2015 16:13:38 +0200 Message-ID: <54EC8712.5060104@redhat.com> References: <7529e243896615deb7d93e6080dfd2aced92bf86.1424774816.git.pmatilai@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev-VfR2kkLFssw@public.gmane.org" To: "Mcnamara, John" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 02/24/2015 03:34 PM, Mcnamara, John wrote: >> -----Original Message----- >> From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Panu Matilainen >> Sent: Tuesday, February 24, 2015 10:47 AM >> To: dev-VfR2kkLFssw@public.gmane.org >> Subject: [dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc - >> dumpversion' output >> >> Commit 71f0ab1849b4fc3ca928deb566df12ca725ed150 broke compilation on some >> versions of Debian and Ubuntu where gcc has been modified to only emit >> MAJOR.MINOR part of the version from 'gcc -dumpversion'. >> Drop the micro-version from gcc version comparisons to work around this, >> it wasn't being used for anything anyway. >> >> -ifeq ($(shell test $(GCC_VERSION) -ge 440 && echo 1), 1) >> +ifeq ($(shell test $(GCC_VERSION) -ge 44 && echo 1), 1) > > Hi, > > I see this has been applied already but to me this version is less clear than the previous patch version. > > And are we sure we won't need the micro-version. If we do, to account for something broken in a point release of gcc, we will have to redo this patch again. Sure? I'm not enough of a fool to say yes to a question like that. I just know it hasn't been needed before, and it seems unlikely it will be needed later on either, gcc micro-version updates tend to be conservative. My only interest here was to fix the version comparisons in a way that makes gcc 5 naturally supported, and I dont really give a damn whether there's a micro-version involved or not :) If you feel strongly about it, send a patch. I'm not going to object. - Panu -