From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: Re: [PATCH 5/5] Fix usage of fgets in various places Date: Wed, 25 Feb 2015 07:37:58 +0200 Message-ID: <54ED5FB6.3020608@redhat.com> References: <1424700600-1765-1-git-send-email-pawelx.wodkowski@intel.com> <1424700600-1765-6-git-send-email-pawelx.wodkowski@intel.com> <20150223080035.001417e8@urahara> <54EC4261.6050804@redhat.com> <20150224110143.6be781f4@urahara> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Stephen Hemminger Return-path: In-Reply-To: <20150224110143.6be781f4@urahara> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 02/24/2015 09:01 PM, Stephen Hemminger wrote: > On Tue, 24 Feb 2015 11:20:33 +0200 > Panu Matilainen wrote: > >> The tool is technically correct, even if loss of precision might be >> unlikely to occur in this context > > Overflow is not there in the code. > That is why I said "shooting Unicorns"; this is all about > about fixing bugs that don't exist because there is nothing there > in the real world. > > In this code buffer is always something normal in size and does > not exceed 2^32-1. Oh, if the tool is complaining about fixed-size buffers then yeah the the tool is being silly, sorry I didn't actually look up the cases. - Panu -