From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pawel Wodkowski Subject: Re: [PATCH v4 3/7] pmd: igb/ixgbe split nb_q_per_pool to rx and tx nb_q_per_pool Date: Wed, 25 Feb 2015 08:47:53 +0100 Message-ID: <54ED7E29.7000102@intel.com> References: <1421672551-11652-1-git-send-email-pawelx.wodkowski@intel.com> <1424361289-30718-1-git-send-email-pawelx.wodkowski@intel.com> <1424361289-30718-4-git-send-email-pawelx.wodkowski@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit To: "Ouyang, Changchun" , "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 2015-02-25 04:24, Ouyang, Changchun wrote: > > >> -----Original Message----- >> From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Pawel Wodkowski >> Sent: Thursday, February 19, 2015 11:55 PM >> To: dev-VfR2kkLFssw@public.gmane.org >> Subject: [dpdk-dev] [PATCH v4 3/7] pmd: igb/ixgbe split nb_q_per_pool to rx >> and tx nb_q_per_pool >> [...] >> >> /* check valid queue number */ >> - if ((nb_rx_q > RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool) || >> - (nb_tx_q > RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool)) { >> + if ((nb_rx_q > RTE_ETH_DEV_SRIOV(dev).nb_tx_q_per_pool) > > Here, how about use nb_rx_q_per_pool to replace nb_tx_q_per_pool ? > so it will be more clear to check rx queue number. Yes, this should be nb_rx_q_per_pool. I missed this, because in next patch I moved this and corrected "on the fly" :). I will correct this in next version. -- Pawel