From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pawel Wodkowski <pawelx.wodkowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] af_packet: Fix some klocwork errors
Date: Thu, 26 Feb 2015 09:44:02 +0100
Message-ID: <54EEDCD2.20107@intel.com>
References: <1424932947-14750-1-git-send-email-changchun.ouyang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: dev-VfR2kkLFssw@public.gmane.org
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1424932947-14750-1-git-send-email-changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On 2015-02-26 07:42, Ouyang Changchun wrote:
> Fix possible memory leak issue: free kvlist before return;
> Fix possible resource lost issue: close qssockfd before return;
>
> Signed-off-by: Changchun Ouyang <changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
>   lib/librte_pmd_af_packet/rte_eth_af_packet.c | 11 +++++++++--
>   1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_pmd_af_packet/rte_eth_af_packet.c b/lib/librte_pmd_af_packet/rte_eth_af_packet.c
> index 80e9bdf..cf8f4fa 100644
> --- a/lib/librte_pmd_af_packet/rte_eth_af_packet.c
> +++ b/lib/librte_pmd_af_packet/rte_eth_af_packet.c
> @@ -694,6 +694,8 @@ error:
>   		}
>   		rte_free(*internals);
>   	}
> +	if (qsockfd != -1)
> +		close(qsockfd);
>   	return -1;
>   }
>
> @@ -822,16 +824,21 @@ rte_pmd_af_packet_devinit(const char *name, const char *params)
>
>   		ret = rte_kvargs_process(kvlist, ETH_AF_PACKET_IFACE_ARG,
>   		                         &open_packet_iface, &sockfd);
> -		if (ret < 0)
> +		if (ret < 0) {
> +			rte_kvargs_free(kvlist);
>   			return -1;
> +		}
>   	}
>
>   	ret = rte_eth_from_packet(name, &sockfd, numa_node, kvlist);
>   	close(sockfd); /* no longer needed */
>
> -	if (ret < 0)
> +	if (ret < 0) {
> +		rte_kvargs_free(kvlist);
>   		return -1;
> +	}
>
> +	rte_kvargs_free(kvlist);
>   	return 0;
>   }
>
>

This patch is correct but it would be good to rework it to have common 
error exit point like in rte_pmd_init_internals() function you changed.

-- 
Pawel