From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chas Williams <3chas3@gmail.com> Subject: Re: [PATCH 1/2 v2] build: add option to override max ethports Date: Tue, 5 Feb 2019 16:08:02 -0500 Message-ID: <54dc55b6-aa63-7390-3b7a-2ffbc7f1e2f2@gmail.com> References: <20190131021858.5832-1-3chas3@gmail.com> <20190131235326.10648-1-3chas3@gmail.com> <20190204094906.GC21148@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, thomas@monjalon.net To: Bruce Richardson Return-path: Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by dpdk.org (Postfix) with ESMTP id 7E4C35F28 for ; Tue, 5 Feb 2019 22:08:04 +0100 (CET) Received: by mail-qt1-f196.google.com with SMTP id y4so70072qtc.10 for ; Tue, 05 Feb 2019 13:08:04 -0800 (PST) In-Reply-To: <20190204094906.GC21148@bricha3-MOBL.ger.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/4/19 4:49 AM, Bruce Richardson wrote: > On Thu, Jan 31, 2019 at 06:53:25PM -0500, Chas Williams wrote: >> Allow users and packagers to override the default RTE_MAX_ETHPORTS. >> This adds a new meson option, max_ethports which defaults to the >> current value. >> > > Actually in this v2, you have changed it to 64 from 32. :-) Otherwise all > fine, but perhaps this can be fixed on apply if no v3. Oops. I can make it 32 again. > >> Signed-off-by: Chas Williams <3chas3@gmail.com> >> Acked-by: Bruce Richardson >> --- >> config/meson.build | 1 + >> config/rte_config.h | 1 - >> meson_options.txt | 2 ++ >> 3 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/config/meson.build b/config/meson.build >> index db32499b3..e59507065 100644 >> --- a/config/meson.build >> +++ b/config/meson.build >> @@ -103,6 +103,7 @@ endforeach >> # set other values pulled from the build options >> dpdk_conf.set('RTE_MAX_LCORE', get_option('max_lcores')) >> dpdk_conf.set('RTE_MAX_NUMA_NODES', get_option('max_numa_nodes')) >> +dpdk_conf.set('RTE_MAX_ETHPORTS', get_option('max_ethports')) >> dpdk_conf.set('RTE_LIBEAL_USE_HPET', get_option('use_hpet')) >> dpdk_conf.set('RTE_EAL_ALLOW_INV_SOCKET_ID', get_option('allow_invalid_socket_id')) >> # values which have defaults which may be overridden >> diff --git a/config/rte_config.h b/config/rte_config.h >> index d3732e953..7606f5d7b 100644 >> --- a/config/rte_config.h >> +++ b/config/rte_config.h >> @@ -51,7 +51,6 @@ >> #define RTE_PKTMBUF_HEADROOM 128 >> >> /* ether defines */ >> -#define RTE_MAX_ETHPORTS 32 >> #define RTE_MAX_QUEUES_PER_PORT 1024 >> #define RTE_ETHDEV_QUEUE_STAT_CNTRS 16 >> #define RTE_ETHDEV_RXTX_CALLBACKS 1 >> diff --git a/meson_options.txt b/meson_options.txt >> index 574054597..499573ed4 100644 >> --- a/meson_options.txt >> +++ b/meson_options.txt >> @@ -18,6 +18,8 @@ option('lib_musdk_dir', type: 'string', value: '', >> description: 'path to the MUSDK library installation directory') >> option('machine', type: 'string', value: 'native', >> description: 'set the target machine type') >> +option('max_ethports', type: 'string', value: '64', >> + description: 'maximum number of Ethernet devices in EAL') >> option('max_lcores', type: 'string', value: '128', >> description: 'maximum number of cores/threads supported by EAL') >> option('max_numa_nodes', type: 'string', value: '4', >> -- >> 2.17.2 >>