From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gonzalez Monroy, Sergio" Subject: Re: [PATCH v2 1/4] mk: Remove combined library and related options Date: Fri, 13 Mar 2015 16:38:10 +0000 Message-ID: <55031272.9020907@intel.com> References: <1422544811-26385-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1426177681-16931-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1426177681-16931-2-git-send-email-sergio.gonzalez.monroy@intel.com> <20150313090759.6173dc49@urahara> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Stephen Hemminger Return-path: In-Reply-To: <20150313090759.6173dc49@urahara> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 13/03/2015 16:07, Stephen Hemminger wrote: > On Thu, 12 Mar 2015 16:27:58 +0000 > Sergio Gonzalez Monroy wrote: > >> Remove CONFIG_RTE_BUILD_COMBINE_LIBS and CONFIG_RTE_LIBNAME. >> >> Signed-off-by: Sergio Gonzalez Monroy >> --- > NAK. The combined library is good and useful for those who want simplicity > and build with static library. > > It is not clear what you are trying to solve. As I mentioned in other post, you can merge multiple archives into a single/combined one pretty easily. I think we can agree that it is not useful for shared libraries, and with versioning in place, combined shared library will be broken the moment we version an API. I don't think we need build config options just for the combined static library when we can achieve the same result with a simple script post build. Sergio